[Digikam-devel] [digikam] [Bug 332280] New: digikam-4.0.0-beta3/core/libs/dimg/filters/transform/freerotationfilter.cpp:94] -> [/home/dcb/rpmbuild/BUILD/digikam-4.0.0-beta3/core/libs/dimg/filters/transform/freerotationfilter.cpp:92]: (style) Same expression on both sides of '||'.

[dcb314 at hotmail.com]

https://bugs.kde.org/show_bug.cgi?id=332280

            Bug ID: 332280
           Summary: digikam-4.0.0-beta3/core/libs/dimg/filters/transform/f
                    reerotationfilter.cpp:94] ->
                    [/home/dcb/rpmbuild/BUILD/digikam-4.0.0-beta3/core/lib
                    s/dimg/filters/transform/freerotationfilter.cpp:92]:
                    (style) Same expression on both sides of '||'.
    Classification: Unclassified
           Product: digikam
           Version: 4.0.0-beta3
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: Filters
          Assignee: digikam-devel at kde.org
          Reporter: dcb314 at hotmail.com

Source code is

    if (p1.x() < 0 ||
        p2.y() < 0 ||
        p1.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

Maybe something like

    if (p1.x() < 0 ||
        p1.y() < 0 ||
        p2.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

was intended.

-- 
You are receiving this mail because:
You are the assignee for the bug.