[Digikam-devel] [digikam] [Bug 331578] digikam deadlocks on batch renaming/moving images

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=331578

Marcel Wiesweg <marcel.wiesweg at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/010d0293d322ce458d00ef1
                   |                            |ff35ac90562ef7da6

--- Comment #2 from Marcel Wiesweg <marcel.wiesweg at gmx.de> ---
Git commit 010d0293d322ce458d00ef1ff35ac90562ef7da6 by Marcel Wiesweg.
Committed on 04/03/2014 at 12:41.
Pushed by mwiesweg into branch 'master'.

Reorder mutex locks - the ImageInfo ReadWriteLock must remain an "inner",
transparent mutex.
It is called from a place where DatabaseAccess is locked, so DatabaseAccess
must not be
locked from a place where the ImageInfo lock is held.
To reduce by one or two mutex locks, consolidate read operations at one place
and
return the hash from a local variable which is in sync with the cached hash.
(note: we do not rule out a parallel operation between the DatabaseAccess and
the
writing of the cached values. it's so far acceptable for a read cache.)

CCMAIL: mike at mghansen.de

M  +22   -11   libs/database/imageinfo.cpp

http://commits.kde.org/digikam/010d0293d322ce458d00ef1ff35ac90562ef7da6

-- 
You are receiving this mail because:
You are the assignee for the bug.