[Digikam-devel] Review Request 119201: Be explicit with OpenCV components

Vadim Zhukov persgray at gmail.com
Wed Jul 23 10:22:59 BST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Июль 23, 2014, 1:22 п.п.)

Review request for Digikam.


Add imgproc to list of OpenCV components, should unbreak build on OS X.

Repository: digikam


This makes Digikam being explicit in what OpenCV components are needed. This results in less number of libraries to be linked to. As a result, Digikam starts a bit faster, eats a bit less memory and makes downstream (packagers) a bit more happy. Also it helps in cases when OpenCV package is split (for example, with non-free components separated) - without explicit mentioning of what components are needed, it's not clear will Digikam link to some components or not.

Diffs (updated)

  CMakeLists.txt d591a2f 
  tests/imgqsort/detectblur/CMakeLists.txt 29df499 
  tests/imgqsort/detectcompression/CMakeLists.txt 73ba98d 
  tests/imgqsort/detectnoise/CMakeLists.txt 18ead8a 

Diff: https://git.reviewboard.kde.org/r/119201/diff/


OpenBSD/i386-CURRENT, KDE 4.11.5+Digikam 3.x and KDE 4.13.2+Digikam 4.x


Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140723/c74642ee/attachment.html>

More information about the Digikam-devel mailing list