[Digikam-devel] Review Request 119413: Limit linking kipi-plugins to OpenCV libraries to only needed components

[Vadim Zhukov]

> On Июль 23, 2014, 11:44 д.п., Gilles Caulier wrote:
> > SET(OpenCV_LIBS)
> > FIND_PACKAGE(OpenCV)    
> > 
> > ^^^there is not limitation about OpenCV component to link RemoveRedEyes tool, as you do with your others opencv patches.

Yep, you're right. I failed at moving patches between OpenBSD Ports and KIPI plugins repos back and forth. I've just updated the patch.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119413/#review62921
-----------------------------------------------------------


On Июль 23, 2014, 1:13 п.п., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119413/
> -----------------------------------------------------------
> 
> (Updated Июль 23, 2014, 1:13 п.п.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> 1. Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
> 2. Limit KIPI plugins linking to only OpenCV components it really uses.
> 
> This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.
> 
> Related reviews: https://git.reviewboard.kde.org/r/119201/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8a4a0d4 
> 
> Diff: https://git.reviewboard.kde.org/r/119413/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140723/b5c2d19b/attachment.html>