[Digikam-devel] Review Request 119201: Be explicit with OpenCV components

Vadim Zhukov persgray at gmail.com
Tue Jul 22 21:34:32 BST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Июль 23, 2014, 12:34 д.п.)

Review request for Digikam.


Force resetting OpenCV_LIBS before calling find_package() to make sure no extra libraries sneak in target_link_libraries() calls.
Limit Digikam core to only OpenCV components it really uses.

This, in particular, unbreaks building Digikam on OpenBSD, where different OpenCV components live in different packages. Before the patch, this forced to always have all OpenCV components installed, even if they aren't really needed while neither building or running Digikam.

Related reviews: https://git.reviewboard.kde.org/r/119413/ and https://git.reviewboard.kde.org/r/119414/ . All those three patches should be applied to have an effect on Digikam SC build.

Repository: digikam


This makes Digikam being explicit in what OpenCV components are needed. This results in less number of libraries to be linked to. As a result, Digikam starts a bit faster, eats a bit less memory and makes downstream (packagers) a bit more happy. Also it helps in cases when OpenCV package is split (for example, with non-free components separated) - without explicit mentioning of what components are needed, it's not clear will Digikam link to some components or not.

Diffs (updated)

  tests/imgqsort/detectnoise/CMakeLists.txt 18ead8a 
  CMakeLists.txt d591a2f 
  tests/imgqsort/detectblur/CMakeLists.txt 29df499 
  tests/imgqsort/detectcompression/CMakeLists.txt 73ba98d 

Diff: https://git.reviewboard.kde.org/r/119201/diff/


OpenBSD/i386-CURRENT, KDE 4.11.5+Digikam 3.x and KDE 4.13.2+Digikam 4.x


Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140722/767f1db6/attachment.html>

More information about the Digikam-devel mailing list