[Digikam-devel] Review Request 119201: Be explicit with OpenCV components

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119201/#review62005
-----------------------------------------------------------


As I said previously, wit libkface we have a problem about OpenCV components to active or not. 

The problem is that i don't yet identified which components must still present or not.

The problem is with Face Detection. Running it crash violently digiKam when OpenCV components is missing. So it's simple to check.

To be sure that problem is not on other side, just enable all OpenCV component and run F&ce Detection. If it so not crash, your test env is fine, and you can start to disable OpenCV step by step.

Gilles Caulier

- Gilles Caulier


On July 9, 2014, 5:26 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119201/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 5:26 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> This makes Digikam being explicit in what OpenCV components are needed. This results in less number of libraries to be linked to. As a result, Digikam starts a bit faster, eats a bit less memory and makes downstream (packagers) a bit more happy. Also it helps in cases when OpenCV package is split (for example, with non-free components separated) - without explicit mentioning of what components are needed, it's not clear will Digikam link to some components or not.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d591a2f 
> 
> Diff: https://git.reviewboard.kde.org/r/119201/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.11.5+Digikam 3.x and KDE 4.13.2+Digikam 4.x
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140709/be932cb9/attachment.html>