[Digikam-devel] Review Request 119201: Be explicit with OpenCV components

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119201/#review62002
-----------------------------------------------------------


Which CmakeFiles do you patch exactly ?

There are 3 parts in digiKam which use OpenCV :

1/ digiKam core
2/ Kipi-plugins (RemoveRedEyes tool)
3/ libkface

For 1 and 2 i think it's fine. But for libkface, i'm sure no, because i tried to reduce OpenCV fingerprint to speed up compilation on my computer (2.4.9 version), and digiKam crash due to a side effect in OpenCV (through a simple std::memcpy() call). With all default components, OpenCV do not crash.

See my comment here :

https://bugs.kde.org/show_bug.cgi?id=336650#c3

Gilles Caulier

- Gilles Caulier


On July 9, 2014, 5:26 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119201/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 5:26 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> This makes Digikam being explicit in what OpenCV components are needed. This results in less number of libraries to be linked to. As a result, Digikam starts a bit faster, eats a bit less memory and makes downstream (packagers) a bit more happy. Also it helps in cases when OpenCV package is split (for example, with non-free components separated) - without explicit mentioning of what components are needed, it's not clear will Digikam link to some components or not.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d591a2f 
> 
> Diff: https://git.reviewboard.kde.org/r/119201/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.11.5+Digikam 3.x and KDE 4.13.2+Digikam 4.x
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140709/ea4d9522/attachment.html>