[Digikam-devel] [digikam] [Bug 330230] Memory leak in Image Quality Sorter

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=330230

--- Comment #3 from Gilles Caulier <caulier.gilles at gmail.com> ---
Gowthan, 

This evening from IRC channel, a thread about this entry has give more
important information:

[23:10] <rhenders> I'm seeing some pretty big memory leaks in Image Quality
sorter in 4.0.0-beta2:  https://gist.github.com/bitflippersanonymous/8530225
[23:11] <rhenders> Built from source on Ubuntu/AMD64
[23:11] <rhenders> I looked for existing bugs but couldn't find any, thought
I'd check here before filing
[23:12] <teprrr> uhu, that looks leaky indeed :o
[23:13] <teprrr> problem is here:            d->imgqsort = new ImgQSort(dimg,
d->quality, &pick);
[23:13] <rhenders> It grows to 100GB for my collection of 5k pictures.
[23:13] <rhenders> I could build debug and get line numbers, ...    what file
is that in?
[23:13] <teprrr> most likely. run() is being called multiple times, and that
new gets called all the time then
[23:14] <teprrr> digikam/utilities/maintenance/imagequalitytask.cpp
[23:14] <teprrr> line 110
[23:15] <teprrr> if that isn't destroyed somewhere in the result handler that's
most likely the leaker
[23:16] <teprrr> DImg there is the image data itself, which may be heavy :P
[23:16] <rhenders> There are several leaks in that valgrind log.  The last one
is the largest, but they all look similar
[23:16] <teprrr> but if you can, provide a valgrind log with the debug-info
enabled and report it to the bugs.kde.org :p
[23:16] <teprrr> hmm, related to maintenance tool?
[23:17] <rhenders> I also see leaks when rebuilding thumbnails, but this was
the largest.  I'll rebuild in debug and report it
[23:17] <rhenders> (What's the cmake flag to enable debug)
[23:18] <teprrr> -DCMAKE_BUILD_TYPE=Debug
[23:18] <teprrr> or DebugFull
[23:18] <rhenders> Great, thanks
[23:20] <teprrr> not a problem, I gotta go now away for a while. thanks for
noticing such a bug :)

Gilles Caulier

-- 
You are receiving this mail because:
You are the assignee for the bug.