[Digikam-devel] [digikam] [Bug 330063] digikam, when deleting photo no confirmation, icon stays present

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=330063

Teemu Rytilahti <tpr at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tpr at iki.fi

--- Comment #4 from Teemu Rytilahti <tpr at iki.fi> ---
Some points:
- The check should be outside CameraController, as that is supposedly running
on a separate thread. And at the moment deleteFile() would be called multiple
times in a row (see deleteItems importui.cpp, which in my opinion would be the
correct place for the check.
- You should use use a method, which makes it possible to tick displaying the
dialog off (see dontAskAgainName in constructors)
- Perhaps warningYesNo instead of question? Someone knows better though.
- i18nify the strings (see
http://techbase.kde.org/Development/Tutorials/Localization/i18n), in my opinion
it should display how many files are to be deleted there, see i18np and with
context, i18ncp.
- When checking for the return value, use the enumerator. This case it'd be
KMessageBox::Yes.
- Check the indendation of the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.