[Digikam-devel] Review Request 115487: removed trailing spaces and optimised shear effect

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115487/#review48997
-----------------------------------------------------------



libs/dimg/filters/transform/shearfilter.cpp
<https://git.reviewboard.kde.org/r/115487/#comment34596>

    Fwiw, the original code is easier to read to me...you should also merge the comments



libs/dimg/filters/transform/shearfilter.cpp
<https://git.reviewboard.kde.org/r/115487/#comment34597>

    I don't see a way this could be negative...? Iow, why the fabs here?


- Martin Klapetek


On Feb. 4, 2014, 9:10 p.m., Heena Mahour wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115487/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 9:10 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> -Removed the trailing spaces
> -Removed redundant code
> -Required absolute value so used fabs()
> 
> 
> Diffs
> -----
> 
>   libs/dimg/filters/transform/shearfilter.cpp 96a4534 
> 
> Diff: https://git.reviewboard.kde.org/r/115487/diff/
> 
> 
> Testing
> -------
> 
> yes,works fine.
> 
> 
> Thanks,
> 
> Heena Mahour
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140205/85e43b1b/attachment.html>