[Digikam-devel] [digikam] [Bug 342229] crash attempting to rotate empty (NULL) thumbnail

[RJVB]

https://bugs.kde.org/show_bug.cgi?id=342229

--- Comment #5 from RJVB <rjvbertin at gmail.com> ---
Created attachment 90133
  --> https://bugs.kde.org/attachment.cgi?id=90133&action=edit
I think the code should do this

Salut Gilles,

I think the calculation of line2 is incorrect: the very first time it is
effectively initialised to `data + h * w`, which is just outside the valid
image data. I've attached a patch that makes this correction for 180°
rotations, but maybe you ought to double-check the other cases too ... ;)
In any case I'm no longer seeing crashes with this patch.

And I stand corrected: as usual this (probably) wasn't a compiler bug but just
another proof how testing with other compilers and on other platforms is an
almost perfect way to find errors that somehow slip through on your usual
platform.

-- 
You are receiving this mail because:
You are the assignee for the bug.