[Digikam-devel] [digikam] [Bug 318726] Some BQM tools in a workflow don't restore (all) parameters properly [patch]

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=318726

--- Comment #15 from Gilles Caulier <caulier.gilles at gmail.com> ---
As you have figured out some code missing in settings XML conversion engine, i
certainly forget similar codes into other BQM tools. Your patch touch the
common queue settings, not separated BQM tool.

In fact, Editor tools and BQM tools use common code about filter to use in a
queue.
Filters are defined into core/libs/dimg/filters/

Not all filters from Editor are ported yet to BQM. See list on
core/imageplugins/TODO file.

A filter define 3 parts :

- an engine to process image, as you pass an image, it processed, and a target
image is provided. ex : 
- a settings container, to pass to engine to tune filter effect. This container
is used by BQM to get and set from XML to settings and vis-versa. Conversion is
done through BatchToolSet, BatchToolSettings, and WorkflowManager classes from
BQM. To simplify, filter settings stored in container, are converted as a QMap
of (QString, QVariant) pair and converted by Qt automatically to XML in
Workflow manager loops. Note that XML conversion is only used in BQM, not
Editor. Editor use VersionManager engine which is mostly complicated and we
don't need it in BQM.
- a setttings widget which permit to BQM and Editor to show all settings in
GUI.

Gilles

-- 
You are receiving this mail because:
You are the assignee for the bug.