[Digikam-devel] New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Sun Aug 17 17:10:59 BST 2014
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
Defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1231814: Dereference before null check (REVERSE_INULL)
/mnt/devel/GIT/4.x/core/digikam/views/digikamview.cpp: 1287 in Digikam::DigikamView::slotAlbumRefresh()()
** CID 1231815: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/4.x/core/digikam/views/leftsidebarwidgets.cpp: 1254 in Digikam::GPSSearchSideBarWidget::Private::Private()()
** CID 1231816: Unused pointer value (UNUSED_VALUE)
/mnt/devel/GIT/4.x/core/digikam/views/leftsidebarwidgets.cpp: 1339 in Digikam::GPSSearchSideBarWidget::showNonGeolocatedItems()()
** CID 1231817: Unused pointer value (UNUSED_VALUE)
/mnt/devel/GIT/4.x/core/digikam/views/leftsidebarwidgets.cpp: 343 in Digikam::TagViewSideBarWidget::setNoTagsAlbum()()
________________________________________________________________________________________________________
*** CID 1231814: Dereference before null check (REVERSE_INULL)
/mnt/devel/GIT/4.x/core/digikam/views/digikamview.cpp: 1287 in Digikam::DigikamView::slotAlbumRefresh()()
1281 Album* const album = d->iconView->currentAlbum();
1282
1283 ThumbsGenerator* const tool = new ThumbsGenerator(true, album->id());
1284 tool->start();
1285
1286 // if physical album, schedule a collection scan of current album's path
>>> CID 1231814: Dereference before null check (REVERSE_INULL)
>>> Null-checking "album" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1287 if (album && album->type() == Album::PHYSICAL)
1288 {
1289 NewItemsFinder* const tool = new NewItemsFinder(NewItemsFinder::ScheduleCollectionScan,
1290 QStringList() << static_cast<PAlbum*>(album)->folderPath());
1291
1292 connect(tool, SIGNAL(signalComplete()),
________________________________________________________________________________________________________
*** CID 1231815: Uninitialized pointer field (UNINIT_CTOR)
/mnt/devel/GIT/4.x/core/digikam/views/leftsidebarwidgets.cpp: 1254 in Digikam::GPSSearchSideBarWidget::Private::Private()()
1248 class GPSSearchSideBarWidget::Private
1249 {
1250 public:
1251 Private() :
1252 gpsSearchView(0)
1253 {
>>> CID 1231815: Uninitialized pointer field (UNINIT_CTOR)
>>> Non-static class member "nonGPSBtn" is not initialized in this constructor nor in any functions that it calls.
1254 }
1255
1256 GPSSearchView* gpsSearchView;
1257 QPushButton* nonGPSBtn;
1258 };
1259
________________________________________________________________________________________________________
*** CID 1231816: Unused pointer value (UNUSED_VALUE)
/mnt/devel/GIT/4.x/core/digikam/views/leftsidebarwidgets.cpp: 1339 in Digikam::GPSSearchSideBarWidget::showNonGeolocatedItems()()
1333 writer.finishField();
1334 writer.finishGroup();
1335 writer.finish();
1336 QString xml = writer.xml();
1337
1338 QString title = SAlbum::getTemporaryTitle(DatabaseSearch::AdvancedSearch);
>>> CID 1231816: Unused pointer value (UNUSED_VALUE)
>>> Pointer "album" returned by "Digikam::AlbumManager::instance()->findSAlbum(title)" is overwritten.
1339 SAlbum* album = AlbumManager::instance()->findSAlbum(title);
1340 album = AlbumManager::instance()->findSAlbum(SAlbum::getTemporaryTitle(DatabaseSearch::AdvancedSearch));
1341 int id;
1342
1343 if(album)
1344 {
________________________________________________________________________________________________________
*** CID 1231817: Unused pointer value (UNUSED_VALUE)
/mnt/devel/GIT/4.x/core/digikam/views/leftsidebarwidgets.cpp: 343 in Digikam::TagViewSideBarWidget::setNoTagsAlbum()()
337 writer.finishField();
338 writer.finishGroup();
339 writer.finish();
340 QString xml = writer.xml();
341
342 QString title = SAlbum::getTemporaryTitle(DatabaseSearch::AdvancedSearch);
>>> CID 1231817: Unused pointer value (UNUSED_VALUE)
>>> Pointer "album" returned by "Digikam::AlbumManager::instance()->findSAlbum(title)" is overwritten.
343 SAlbum* album = AlbumManager::instance()->findSAlbum(title);
344 album = AlbumManager::instance()->findSAlbum(SAlbum::getTemporaryTitle(DatabaseSearch::AdvancedSearch));
345 int id;
346
347 if(album)
348 {
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com/projects/285?tab=overview
To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py
More information about the Digikam-devel
mailing list