[Digikam-devel] [digikam] [Bug 318873] digiKam crashes when clicking on image in thumbnails [patch]

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=318873

--- Comment #17 from Marcel Wiesweg <marcel.wiesweg at gmx.de> ---
Simon, are you available for a small test (it is you who can reliably reproduce
this crash)
i have an interesting idea: I believe the histogram loads the image, then the
histogram is computed. During that time the preview task takes the data from
the cache but may not copy it. The preview is rotated in the PreviewTask. That
fits well with your backtraces.
This could be a subtle, difficult to spot bug explaining some of our crashes.

Can you test if this fixes your problem instead of your proposed patch?

diff --git a/libs/threadimageio/previewtask.cpp
b/libs/threadimageio/previewtask.cpp
index 5bb39fa..9763a34 100644
--- a/libs/threadimageio/previewtask.cpp
+++ b/libs/threadimageio/previewtask.cpp
@@ -104,10 +104,10 @@ void PreviewLoadingTask::execute()
             // image is found in image cache, loading is successful
             m_img = *cachedImg;

-            if (accessMode() == LoadSaveThread::AccessModeReadWrite)
-            {
+            //if (accessMode() == LoadSaveThread::AccessModeReadWrite)
+            //{
                 m_img = m_img.copy();
-            }
+            //}

             // rotate if needed - images are unrotated in the cache,
             // except for RAW images, which are already rotated by dcraw.

-- 
You are receiving this mail because:
You are the assignee for the bug.