[Digikam-devel] [digikam] [Bug 326953] Add loadEmbeddedPreview(QByteArray, QBuffer)

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=326953

Gilles Caulier <caulier.gilles at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caulier.gilles at gmail.com

--- Comment #2 from Gilles Caulier <caulier.gilles at gmail.com> ---
>From your patch you force libkdcraw client application to compile with libraw
througn libkdcraw/kdcraw.h header :

+//LibRaw includes
+
+#include <libraw/libraw.h>

This is weird. client application don't need this dependency.
To fix it, move this method :

 private:
+    // implements loadEmbeddedPreview once the LibRaw buffer is opened
+    static bool loadEmbeddedPreview(QByteArray&, LibRaw&);

... to kdcraw_p.h/.cpp and remove libraw header include from shared libkdcraw
header.

If you update this patch, it will be can included to git/master for next KDE
4.12. Do you have a git developer account ?

Best

Gilles Caulier

-- 
You are receiving this mail because:
You are the assignee for the bug.