[Digikam-devel] Review Request 113519: Very draft implemetation of External Tools feature for BQM

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113519/#review42963
-----------------------------------------------------------

Ship it!


Ship It!

- Gilles Caulier


On Oct. 31, 2013, 1:32 p.m., Yuri Samoilenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113519/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 1:32 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> It is my first review. I have some questions about direction of my work.
> 
> The core of the patch in moving Queue processing internals out of overburdened QueueMgrWindow to simple QueueMgr.
> QueueMgr responsible for procession only one queue from begining to the end. To implement "group-file-passing-to-extrenal-tool" QueueMgr intercept all signals from underlying taksk and and composing "result url list" which will be sended to external tool in the end.
> 
> Configuring of External Tools impemented in new tab in BQM QueueSettings and selecting tool for current processing int "Target" tab in BQM QueueSettings.
> There is no interaction within "External Tools" and "Target Album" in Target tab yet.
> 
> Any comments?
> 
> 
> Diffs
> -----
> 
>   utilities/queuemanager/CMakeLists.txt 910752c 
>   utilities/queuemanager/main/etrunner.h PRE-CREATION 
>   utilities/queuemanager/main/etrunner.cpp PRE-CREATION 
>   utilities/queuemanager/main/etwidget.h PRE-CREATION 
>   utilities/queuemanager/main/etwidget.cpp PRE-CREATION 
>   utilities/queuemanager/main/etwidget.ui PRE-CREATION 
>   utilities/queuemanager/main/queuemgr.h PRE-CREATION 
>   utilities/queuemanager/main/queuemgr.cpp PRE-CREATION 
>   utilities/queuemanager/main/queuemgrwindow.cpp 8cd65bd 
>   utilities/queuemanager/main/queuemgrwindow_p.h 7bf44da 
>   utilities/queuemanager/manager/queuesettings.h 522c46f 
>   utilities/queuemanager/manager/task.cpp d825380 
>   utilities/queuemanager/views/queuesettingsview.cpp d9b89b3 
> 
> Diff: http://git.reviewboard.kde.org/r/113519/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuri Samoilenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20131104/617687dd/attachment.html>