[Digikam-devel] [digikam] [Bug 327124] New: Add loadHalfPreview reading from QBuffer

[Martin Kyral]

https://bugs.kde.org/show_bug.cgi?id=327124

            Bug ID: 327124
           Summary: Add loadHalfPreview reading from QBuffer
    Classification: Unclassified
           Product: digikam
           Version: unspecified
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkdcraw
          Assignee: digikam-devel at kde.org
          Reporter: sine.nomine at centrum.cz
                CC: caulier.gilles at gmail.com

Created attachment 83331
  --> https://bugs.kde.org/attachment.cgi?id=83331&action=edit
proposed patch

During implementation of the RAW preview support in gwenview, a need for
loadHalfPreview able of loading the RAW data from QBuffer and returning JPEG
data in QByteArray arose.
I decided to implement variants of loadHalfPreview and loadRawPreview returning
data in a QByteArray (JPEG format, but it would be easily implementable to
allow passing the desired format as optional parameter for loadHalfPreview. In
loadRawPreview that would be senseless as loadEmbeddedPreview is always JPEG).

If this API change is not desired, I'll implement loadHalfPreview(QImage,
QBuffer) as a minimal variant, leaving the conversion to JPEG in QByteArray on
gwenview side.

Proposed patch is attached (fixing some typos in the documentation comments,
too).

+++ This bug was initially created as a clone of Bug #326953 +++

During implementation of the RAW preview support in gwenview, a need for
loadEmbeddedPreview able of loading the RAW data from QBuffer (not file) arose.
Temporarily, I've implemented the function within gwenview. For the sake of
better maintainability of the code it would be nice to have this feature
implemented directly in libkdcraw. Proposed patch is attached.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.