[Digikam-devel] [showfoto] [Bug 163293] Only generate thumbnail when needed [patch]

AMAN KAOOR amanjmd100 at gmail.com
Sun May 19 06:57:49 BST 2013


AMAN KAOOR <amanjmd100 at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #79928|0                           |1
        is obsolete|                            |

--- Comment #17 from AMAN KAOOR <amanjmd100 at gmail.com> ---
Created attachment 79959
  --> https://bugs.kde.org/attachment.cgi?id=79959&action=edit

Hi Gilles,

It was right that In my previous patch  ,the thumb-bar was not updated on
transformation of any of the images because I removed the slotGotThumbnail and
its connection from the thumbnailload thread, so it was not able to repaint the
changes in image, in the thumb-bar after the image was transformed.

So in this patch I removed the connection from the constructor, so that initial
loading and painting is done only by viewportPaintEvent, and not the
slotGotThumbnail item->repaint() function which is causing the extra painting
computation .I have transferred this connection to the void
ThumbBarView::invalidateThumb function , which is called only when we save the
transformed image. Because it is called by the item url ,so the item->repaint()
function is only called for the item which is transformed and the item is

I am submitting the new patch obseleting the previous one. Please review it.

You are receiving this mail because:
You are the assignee for the bug.

More information about the Digikam-devel mailing list