[Digikam-devel] [showfoto] [Bug 163293] Only generate thumbnail when needed [patch]

AMAN KAOOR amanjmd100 at gmail.com
Fri May 17 10:00:26 BST 2013


AMAN KAOOR <amanjmd100 at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #79764|0                           |1
        is obsolete|                            |
  Attachment #79881|0                           |1
        is obsolete|                            |
  Attachment #79886|0                           |1
        is obsolete|                            |

--- Comment #15 from AMAN KAOOR <amanjmd100 at gmail.com> ---
Created attachment 79928
  --> https://bugs.kde.org/attachment.cgi?id=79928&action=edit

Hi Gilles,

Sorry for the puzzle. I have attached  the final patch and have removed all the
previous ones.

The repaint function called in slotGotThumbnail was painting the pixmap to the
rectangles , before the viewportPaintEvent ,which was causing an extra  CPU
usage . If this Slot is not called, only the viewportPaintevent function paints
the pixmap , not the contentsRepaint() ,thereby reducing the CPU usage.
In this patch, I have removed slotGotThumbnail function and its connections as
it's functions are already being performed by viewportPaintEvent and there is
no need to slotGotThumbnail to load the thumbnails.
Removing this function decreases the cpu usage of all cores to a great extend
as shown in the images.

Please review it.


You are receiving this mail because:
You are the assignee for the bug.

More information about the Digikam-devel mailing list