[Digikam-devel] Review Request 103701: Install LibKexiv2Config.cmake
Alexander Neundorf
neundorf at kde.org
Tue May 7 18:17:47 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103701/#review32210
-----------------------------------------------------------
Ship it!
Seems to be ok now.
- Alexander Neundorf
On May 7, 2013, 7:18 a.m., Yury Kudryashov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103701/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 7:18 a.m.)
>
>
> Review request for Build System and Digikam.
>
>
> Description
> -------
>
> Now
> find_package(libkexiv2 CONFIG)
> finds LibKexiv2, removing need for large FindKexiv2.cmake script.
>
> I've decided to install libkexiv2-config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
>
> Also, I'm not sure about libkexiv2-config-version.cmake. I'm ready to adjust the default policy if someone will tell me about correct algorithm (SONAME? Same major version? Same major/minor? something else?).
>
>
> Diffs
> -----
>
> CMakeLists.txt 8c89503ffb2de66be682af3b262756519db3af49
> libkexiv2-config.cmake.in PRE-CREATION
> libkexiv2/CMakeLists.txt c706d820f54b412f45131a14276b13bfc07255a1
>
> Diff: http://git.reviewboard.kde.org/r/103701/diff/
>
>
> Testing
> -------
>
> $ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK
>
>
> Thanks,
>
> Yury Kudryashov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130507/d73592e4/attachment.html>
More information about the Digikam-devel
mailing list