[Digikam-devel] Review Request 109017: Add Olympus' LensModel to DMetadata

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109017/#review29635
-----------------------------------------------------------


Patch is fine for me and is ready to be commit to git/master.

This will close this bugzilla entry : #311295

Gilles Caulier

- Gilles Caulier


On March 21, 2013, 2:11 p.m., Teemu Rytilahti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109017/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 2:11 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.
> 
> 
> This addresses bug 311295.
>     http://bugs.kde.org/show_bug.cgi?id=311295
> 
> 
> Diffs
> -----
> 
>   libs/dmetadata/dmetadata.cpp 8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9 
> 
> Diff: http://git.reviewboard.kde.org/r/109017/diff/
> 
> 
> Testing
> -------
> 
> Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.
> 
> 
> File Attachments
> ----------------
> 
> Properties bar showing the lens information
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/21/lens.png
> 
> 
> Thanks,
> 
> Teemu Rytilahti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130321/f3c288e6/attachment.html>