[Digikam-devel] Review Request 109048: Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid.

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109048/#review29630
-----------------------------------------------------------


> Soo, to answer to your question, I think adding this special case should be enough for now?

yes, it's fine...

>Nope, I haven't been able to get in touch with the maintainer via e-mail and their Redmine doesn't let me login at all. Sent a new message about the matter to Andreas.

Try to contact Robin Mills <Robin.Mills at novariant.com> instead if Andreas is too busy to respond.

- Gilles Caulier


On Feb. 19, 2013, 9:03 p.m., Teemu Rytilahti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109048/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 9:03 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?
> 
> Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.
> 
> 
> Diffs
> -----
> 
>   libs/dimg/filters/lens/lensfuniface.cpp f2bbb620bfa116cb9f72afa7dc2229d02dafd830 
> 
> Diff: http://git.reviewboard.kde.org/r/109048/diff/
> 
> 
> Testing
> -------
> 
> Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.
> 
> 
> Thanks,
> 
> Teemu Rytilahti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130321/57dde4a2/attachment.html>