[Digikam-devel] Review Request 109048: Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid.

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109048/#review29366
-----------------------------------------------------------


>Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. 

The patch sound fine for me.


>Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?

As Exif.Olympus.FocusDistance is a makernote private tag, not very well documented, it's diffcult to see if this value is different than standard Exif.Image.SubjectDistance tag.

If private tag exist, i suppose that standard exif have been considerated as not enough by Olympus. 


0x9206	37382	Image	Exif.Image.SubjectDistance	SRational	The distance to the subject, given in meters.

0x100c	4108	Olympus	Exif.Olympus.FocusDistance	Rational	Manual focus distance

Note : exiftool do not give a better explaination abou tthis private tag :

http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Olympus.html

What do you plan to add in your patch ?

>Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.

Do you applied a patch to Exiv2 project ?

Gilles Caulier

- Gilles Caulier


On Feb. 19, 2013, 9:03 p.m., Teemu Rytilahti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109048/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 9:03 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> Add FocusDistance from Olympus' MakerNote data. Also return 10000 to the UI when the value is invalid. Makes Lensfun plugin to autodetect the distance. Though started to have second thoughts about this, as the distance to the subject may not be the same as focus distance, can anyone clarify if this is ok or not?
> 
> Note, as of yet this requires a separate patch to exiv2, which I'm going to submit soon to them.
> 
> 
> Diffs
> -----
> 
>   libs/dimg/filters/lens/lensfuniface.cpp f2bbb620bfa116cb9f72afa7dc2229d02dafd830 
> 
> Diff: http://git.reviewboard.kde.org/r/109048/diff/
> 
> 
> Testing
> -------
> 
> Compiled current master and tested the lens correction. Tested also with lensfuniface test to make sure it's working.
> 
> 
> Thanks,
> 
> Teemu Rytilahti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130317/deb1f0ed/attachment.html>