[Digikam-devel] [digikam] [Bug 244422] for better overviewing large image collections, I wish to have a _list_ view

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=244422

--- Comment #32 from Michael G. Hansen <mike at mghansen.de> ---
(In reply to comment #25)
> - For icon, look view-list-details.png from Oxygen for ex. Mine is located
> in /usr/share/icons/oxygen/32x32/actions/

Done, looks better.

> - For tool bar, just patch digikam UI rc file here :

Done.

> In Columns properties from Table-View mode, I can see "Digikam properties". There is a typo. It's must be "digiKam properties"

Done.

>Small tip from cppcheck : Checking tableview_columnfactory.cpp... >[tableview_columnfactory.cpp:251]: (performance) Function parameter 'sourceIndex' should be passed by reference. 

Done.

CID 990525 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK) 1. alloc_new:
Allocating memory by calling "new Digikam::TableViewModelItem". 2. var_assign:
Assigning: "this->rootItem" = "new Digikam::TableViewModelItem". 3.
ctor_dtor_leak: The constructor allocates field "rootItem" of
"Digikam::TableViewModel::Private" but there is no destructor.

That was a "false" positive, because the rotItem was deleted in
TableViewModel's destructor. But I moved the "new Digikam::TableViewModelItem"
to TableViewModel's constructor for consistency.

> Other important point to add is the capability to show Photo Info in columns, as aperture, shutter speed, white balance, etc. In fact all info already hosted in right sidebar from Photograph Properties section. 

Is planned, but I wanted to get the whole concept tested before implementing
all columns.

Michael

-- 
You are receiving this mail because:
You are the assignee for the bug.