[Digikam-devel] query regarding a TODO

[Saurabh Patel]

Hello,
    So what should be done.TODO should be removed or wait for the reply of
one who coded

Thanks

On Mon, Mar 4, 2013 at 5:45 PM, Gilles Caulier <caulier.gilles at gmail.com>wrote:

> I think *m_talker->loggedIn() is a method to check if talker is already
> logged (as it return bool).*
> *
> *
> *I don't coded this tool, so i'm not sure...*
> *
> *
> *As well, for me, code commented can be removed...*
> *
> *
> *Gilles Caulier*
>
>
> 2013/3/4 Saurabh Patel <saurabhpatel7717 at gmail.com>
>
>> Hello,
>>     I was going through kipi-plugins in digikam.In kipi-plugin for
>> picasawebexport I found a TODO on line 320 in picasawebwindow.cpp.I am
>> pasting the whole method here.
>>
>> void PicasawebWindow::slotLoginDone(int errCode, const QString& errMsg)
>> {
>>     m_widget->progressBar()->hide();
>>
>>    * if (errCode == 0 /*TODO&& m_talker->loggedIn()*/)*
>>     {
>>         buttonStateChange(true);
>>         m_token = m_talker->token();
>>         m_widget->m_albumsCoB->clear();
>>         m_talker->listAlbums(m_talker->getUserName());
>>     }
>>     else
>>     {
>>         KMessageBox::error(this, i18n("Picasaweb Call Failed: %1\n",
>> errMsg));
>>     }
>> }
>>
>>
>> I have a question that the method loggedIn is not defined in
>> picasawebtalker so is it to be implemented there.Also is it necessary since
>> signallogindone signal in picasawebtalker is emitted after checking success
>> to get username and password
>>
>> Thanks
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> Digikam-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>>
>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130304/71c6b079/attachment.html>