[Digikam-devel] Fwd: New Defects reported by Coverity Scan for digiKam

[Gilles Caulier]

---------- Forwarded message ----------
From: <scan-admin at coverity.com>
Date: 2013/6/2
Subject: New Defects reported by Coverity Scan for digiKam
To: caulier.gilles at gmail.com



Hi,

Please find the latest report on new defect(s) introduced to digiKam found
with Coverity Scan

Defect(s) Reported-by: Coverity Scan


** CID 1026710: Copy-paste error (COPY_PASTE_ERROR)
/mnt/devel/GIT/3.x/core/libs/database/faces/facetags.cpp: 244


________________________________________________________________________
CID 1026710: Copy-paste error (COPY_PASTE_ERROR)

/mnt/devel/GIT/3.x/core/libs/database/faces/facetags.cpp: 238 ( original)
   235    {
   236        QMap<QString, QString> attributes;
   237        QString uuid = TagsCache::instance()->propertyValue(tagId,
TagPropertyName::kfaceUuid());
>>> "uuid" looks like the original copy.
   238        if (!uuid.isEmpty())
   239        {
   240            attributes["uuid"] = uuid;
   241        }
   242


/mnt/devel/GIT/3.x/core/libs/database/faces/facetags.cpp: 244 (
copy_paste_error)
   241        }
   242
   243        QString fullName =
TagsCache::instance()->propertyValue(tagId, TagPropertyName::person());
>>> CID 1026710: Copy-paste error (COPY_PASTE_ERROR)
>>> "uuid" in "uuid" looks like a copy-paste error.  Should it say
"fullName" instead?
   244        if (!uuid.isEmpty())
   245        {
   246            attributes["fullName"] = fullName;
   247        }
   248

________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com

To unsubscribe from the email notification for new defects,
http://scan5.coverity.com/cgi-bin/unsubscribe.py
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130602/e06cfb21/attachment.html>