[Digikam-devel] New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan

Defect(s) Reported-by: Coverity Scan

	
** CID 1042531: Non-virtual destructor (VIRTUAL_DTOR)

** CID 1042530: Unrecoverable parse warning (PARSE_ERROR)
/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 77

** CID 1042529: Unrecoverable parse warning (PARSE_ERROR)
/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 54

** CID 1042528: Unrecoverable parse warning (PARSE_ERROR)
/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 85

** CID 1042527: Unchecked return value (CHECKED_RETURN)
/mnt/devel/GIT/3.x/extra/kipi-plugins/common/libkipiplugins/tools/kpbinaryiface.cpp: 225


________________________________________________________________________
CID 1042531: Non-virtual destructor (VIRTUAL_DTOR)

/mnt/devel/GIT/3.x/extra/libkgeomap/libkgeomap/itemmarkertiler.cpp: 54 ( nonvirtual_dtor)
   51         * in Tile and its subclasses in order to save memory, since there
   52         * can be a lot of tiles in a MarkerTiler.
   53         */
>>> Class KGeoMap::ItemMarkerTiler::MyTile has a destructor and a pointer to it is upcast to class KGeoMap::AbstractMarkerTiler::Tile which doesn't have a virtual destructor.
   54        ~MyTile()
   55        {
   56        }
   57    
   58        QList<QPersistentModelIndex> markerIndices;
  
________________________________________________________________________
CID 1042530: Unrecoverable parse warning (PARSE_ERROR)

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 77 ( undefined_identifier)
   74    
   75        bool success() const;
   76        void requestAbort();
>>> CID 1042530: Unrecoverable parse warning (PARSE_ERROR)
>>> identifier "RawDecodingSettings" is undefined
   77        void setPreProcessingSettings(bool align, const RawDecodingSettings& settings);
   78        bool getXmpRational(const char* xmpTagName, long& num, long& den, KPMetadata& meta);
   79        float getAverageSceneLuminance(const KUrl& url);
   80        bool startEnfuse(const KUrl::List& inUrls, KUrl& outUrl,
   81                                   const EnfuseSettings& settings,
  

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 77 ( primary_file)
   74    
   75        bool success() const;
   76        void requestAbort();
>>> During compilation of file '/mnt/devel/GIT/3.x/build/extra/kipi-plugins/expoblending/libexpoblending_automoc.cpp'
   77        void setPreProcessingSettings(bool align, const RawDecodingSettings& settings);
   78        bool getXmpRational(const char* xmpTagName, long& num, long& den, KPMetadata& meta);
   79        float getAverageSceneLuminance(const KUrl& url);
   80        bool startEnfuse(const KUrl::List& inUrls, KUrl& outUrl,
   81                                   const EnfuseSettings& settings,
  
________________________________________________________________________
CID 1042529: Unrecoverable parse warning (PARSE_ERROR)

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 54 ( undefined_identifier)
   51        KUrl                outputUrl;
   52        QString             binaryPath;
   53        
>>> CID 1042529: Unrecoverable parse warning (PARSE_ERROR)
>>> identifier "RawDecodingSettings" is undefined
   54        RawDecodingSettings              rawDecodingSettings;
   55        EnfuseSettings      enfuseSettings;		//enfusebinary
   56        
   57        
   58    public:
  

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 54 ( primary_file)
   51        KUrl                outputUrl;
   52        QString             binaryPath;
   53        
>>> During compilation of file '/mnt/devel/GIT/3.x/build/extra/kipi-plugins/expoblending/libexpoblending_automoc.cpp'
   54        RawDecodingSettings              rawDecodingSettings;
   55        EnfuseSettings      enfuseSettings;		//enfusebinary
   56        
   57        
   58    public:
  
________________________________________________________________________
CID 1042528: Unrecoverable parse warning (PARSE_ERROR)

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 85 ( undefined_identifier)
   82                                   const QString& enfusePath, QString& errors);
   83        QString getProcessError(KProcess* const proc) const;
   84        bool startPreProcessing(const KUrl::List& inUrls, ItemUrlsMap& preProcessedMap,
>>> CID 1042528: Unrecoverable parse warning (PARSE_ERROR)
>>> identifier "RawDecodingSettings" is undefined
   85                                          bool align, const RawDecodingSettings& rawSettings,
   86                                          const QString& alignPath, QString& errors);
   87    
   88    Q_SIGNALS:
   89    
  

/mnt/devel/GIT/3.x/extra/kipi-plugins/expoblending/tasks/task.h: 85 ( primary_file)
   82                                   const QString& enfusePath, QString& errors);
   83        QString getProcessError(KProcess* const proc) const;
   84        bool startPreProcessing(const KUrl::List& inUrls, ItemUrlsMap& preProcessedMap,
>>> During compilation of file '/mnt/devel/GIT/3.x/build/extra/kipi-plugins/expoblending/libexpoblending_automoc.cpp'
   85                                          bool align, const RawDecodingSettings& rawSettings,
   86                                          const QString& alignPath, QString& errors);
   87    
   88    Q_SIGNALS:
   89    
  
________________________________________________________________________
CID 1042527: Unchecked return value (CHECKED_RETURN)

/mnt/devel/GIT/3.x/extra/kipi-plugins/common/libkipiplugins/tools/kpbinaryiface.cpp: 225 ( check_return)
   222        QProcess process;
   223        process.setProcessChannelMode(QProcess::MergedChannels);
   224        process.start(possiblePath, m_binaryArguments);
>>> CID 1042527: Unchecked return value (CHECKED_RETURN)
>>> Calling function "QProcess::waitForFinished(int)" without checking return value (as is done elsewhere 4 out of 5 times).
   225        process.waitForFinished();
   226    
   227        if (process.error() != QProcess::FailedToStart)
   228        {
   229            m_isFound = true;
  

/mnt/devel/GIT/3.x/extra/kipi-plugins/common/libkipiplugins/tools/kpbinaryiface.cpp: 225 ( unchecked_value)
   222        QProcess process;
   223        process.setProcessChannelMode(QProcess::MergedChannels);
   224        process.start(possiblePath, m_binaryArguments);
>>> No check of the return value of "process.waitForFinished(30000)".
   225        process.waitForFinished();
   226    
   227        if (process.error() != QProcess::FailedToStart)
   228        {
   229            m_isFound = true;
  
________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan.coverity.com

To unsubscribe from the email notification for new defects, http://scan5.coverity.com/cgi-bin/unsubscribe.py