[Digikam-devel] Review Request 108574: Turned on sorting by pixel size and added sorting by aspect ratio

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108574/#review26360
-----------------------------------------------------------


Thanks Stephen to contribute. I waiting your new patch for future integration into 3.1.0 release.

Gilles Caulier

- Gilles Caulier


On Jan. 28, 2013, 3:46 p.m., Stephen Toothman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108574/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 3:46 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  
> 
> 
> This addresses bug none.
>     http://bugs.kde.org/show_bug.cgi?id=none
> 
> 
> Diffs
> -----
> 
>   digikam/items/digikamimagedelegate.cpp 3e65a85 
>   digikam/items/imagedelegate.cpp 6dfad4f 
>   digikam/items/imagedelegatepriv.h 0ffa233 
>   digikam/main/digikamapp.cpp f9a1206 
>   digikam/utils/albumsettings.h 501213a 
>   digikam/utils/albumsettings.cpp b838479 
>   digikam/utils/tooltipfiller.h d384b82 
>   digikam/utils/tooltipfiller.cpp 57206cb 
>   libs/models/imagesortsettings.h 8db56e7 
>   libs/models/imagesortsettings.cpp cf01336 
>   libs/widgets/itemview/itemviewimagedelegate.h d1c3fd0 
>   libs/widgets/itemview/itemviewimagedelegate.cpp 1a1632c 
>   utilities/setup/setupalbumview.cpp f2d5e7c 
>   utilities/setup/setuptooltip.cpp b1ac814 
> 
> Diff: http://git.reviewboard.kde.org/r/108574/diff/
> 
> 
> Testing
> -------
> 
> I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.
> 
> 
> File Attachments
> ----------------
> 
> local diff I used for porting to the git code base
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/25/core_diff.txt
> 
> 
> Thanks,
> 
> Stephen Toothman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130129/46140316/attachment.html>