[Digikam-devel] Review Request 108574: Turned on sorting by pixel size and added sorting by aspect ratio

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108574/#review26135
-----------------------------------------------------------


Stephen,

Your patch is against digiKam 2.5.0. It must be done against git/master code (future 3.0.0). A lots of code have changed since 2.5.0, and your patch cannot be applied to current implementation and tested.

Please, make a new patch against git/master...

Gilles Caulier

- Gilles Caulier


On Jan. 24, 2013, 3:04 p.m., Stephen Toothman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108574/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 3:04 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  
> 
> 
> This addresses bug none.
>     http://bugs.kde.org/show_bug.cgi?id=none
> 
> 
> Diffs
> -----
> 
>   core/digikam/items/digikamimagedelegate.cpp PRE-CREATION 
>   core/digikam/items/imagedelegate.cpp PRE-CREATION 
>   core/digikam/items/imagedelegatepriv.h PRE-CREATION 
>   core/digikam/main/digikamapp.cpp PRE-CREATION 
>   core/digikam/utils/albumsettings.h PRE-CREATION 
>   core/digikam/utils/albumsettings.cpp PRE-CREATION 
>   core/digikam/utils/tooltipfiller.h PRE-CREATION 
>   core/digikam/utils/tooltipfiller.cpp PRE-CREATION 
>   core/libs/models/imagesortsettings.h PRE-CREATION 
>   core/libs/models/imagesortsettings.cpp PRE-CREATION 
>   core/libs/widgets/itemview/itemviewimagedelegate.h PRE-CREATION 
>   core/libs/widgets/itemview/itemviewimagedelegate.cpp PRE-CREATION 
>   core/utilities/setup/setupalbumview.cpp PRE-CREATION 
>   core/utilities/setup/setuptooltip.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108574/diff/
> 
> 
> Testing
> -------
> 
> I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.
> 
> 
> Thanks,
> 
> Stephen Toothman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130124/5401e215/attachment.html>