[Digikam-devel] Review Request 108382: Make tagging more accessible by keyboard

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108382/#review25359
-----------------------------------------------------------


I take a look to your patch (not yet tested)

Your new d->assignTagAction is not visible to Tags main menu. It's normal ? It just a cached keyboard shortcut ?

Do you see that there is 2 way to manage tags assignment from GUI: 
1/ Tags album view from left sidebar
2/ Tags tree view from right sidebar

If i'm not too wrong you only manage 2/, to force focus on it. Right ?




- Gilles Caulier


On Jan. 13, 2013, 10:16 a.m., Markus Leuthold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108382/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 10:16 a.m.)
> 
> 
> Review request for Digikam, Gilles Caulier and Marcel Wiesweg.
> 
> 
> Description
> -------
> 
> Make tagging more accessible by keyboard
> 
>  * Pressing "T" will focus the tagedit-box.
>  * The tag is applied by pressing enter. Pressing enter a second time will
>    focus the mainwindow and advance to the next image.
>  * The dropdown of the tagedit-box remembers already entered tags, the
>    order of the dropdown items are sorted such that already entered tags appear first.
> 
> 
> Diffs
> -----
> 
>   digikam/main/digikamapp.cpp f9a1206faa0ff2c5f174b74728d45e660bfea599 
>   digikam/main/digikamapp_p.h e4924fc0818715e79919e3ac1de74fbd07e26152 
>   digikam/tags/addtagscompletionbox.cpp 266421c34fe6d939b094d0c0b1dea77065e024ee 
>   digikam/tags/addtagslineedit.h 1eec38c090eaefd592e4cc5c4561fadf04b9de26 
>   digikam/tags/addtagslineedit.cpp abcf5b1f9d9a0340a9838b267faa2637f989bd96 
>   digikam/views/digikamview.h 418dc019256300315a1623d45ad1a7d6e6c484f7 
>   digikam/views/digikamview.cpp b8c2f6408d59a638c0c400b81516eedd5d1a621b 
>   libs/database/albumdb.cpp 2d04b1568e46d59a162be0bfdc2105a6d5bb7d2a 
>   libs/imageproperties/imagedescedittab.h 9b229e451c0d14b34b39c510749f2088b259ef34 
>   libs/imageproperties/imagedescedittab.cpp d607c73ae4a4c19074f18539be8e785fd3110b5f 
>   libs/imageproperties/imagepropertiessidebar.h f6703339fc2e1a5762f8db898e7ad69dddab7868 
> 
> Diff: http://git.reviewboard.kde.org/r/108382/diff/
> 
> 
> Testing
> -------
> 
> I successfully use this feature on a regular basis. Also tested with current HEAD, works fine.
> 
> 
> Thanks,
> 
> Markus Leuthold
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130113/57f00ec6/attachment.html>