[Digikam-devel] [digikamimageplugins] [Bug 284708] Lens Autocorrection overcompensates distortion

Gilles Caulier caulier.gilles at gmail.com
Mon Jan 7 10:37:44 GMT 2013


https://bugs.kde.org/show_bug.cgi?id=284708

--- Comment #2 from Gilles Caulier <caulier.gilles at gmail.com> ---
Git commit 613d004121682d122e9ea7fd9041a7bbc49acb89 by Gilles Caulier.
Committed on 07/01/2013 at 11:34.
Pushed by cgilles into branch 'master'.

Apply patch #76256 from Roman I Khimov to use crop factor from camera, not from
lens data.
Lens crop factor in DB only tells us which crop factor was used for lens
calibration data, but it has nothing to do with shots made on random user's
camera. So the default behaviour should be to use camera's crop factor and only
fallback to lens data if there in no data present for camera. As "this should
not happen" it's appropriate to spit out some debug message in this case.

Ref: http://lensfun.berlios.de/manual/el_lens.html
Ref: http://lensfun.berlios.de/manual/el_camera.html
Related: bug 312766, bug 312764, bug 253941, bug 266204, bug 267613, bug 281783
FIXED-IN: 3.0.0
CCMAIL: roman at khimov.ru

M  +2    -1    libs/dimg/filters/lens/lensfuncameraselector.cpp
M  +1    -1    libs/dimg/filters/lens/lensfuniface.cpp

http://commits.kde.org/digikam/613d004121682d122e9ea7fd9041a7bbc49acb89

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Digikam-devel mailing list