[Digikam-devel] Review Request 109110: Find and external SQLite v2 for digiKam DB 0.7 conversion

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109110/#review27931
-----------------------------------------------------------


Patch is fine for me. You can commit and close bug #237037

Gilles Caulier

- Gilles Caulier


On Feb. 23, 2013, 1:39 p.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109110/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 1:39 p.m.)
> 
> 
> Review request for Digikam and Gilles Caulier.
> 
> 
> Description
> -------
> 
> Instead of rely on an internal copy of SQLite v2, search for an external version of it; if not found, disable the import/conversion of old databases from v0.7, failing directly with an error message.
> 
> Once this is accepted, a second commit will remove the libs/3rdparty/sqlite2 directory.
> 
> 
> This addresses bug 237037.
>     http://bugs.kde.org/show_bug.cgi?id=237037
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cb7967389b60e33eec5e10a9633577d70e8ecbfa 
>   cmake/modules/FindSqlite2.cmake PRE-CREATION 
>   digikam/CMakeLists.txt 71cc34cc05e71f348b193963a30f7c8f0e6daf89 
>   digikam/utils/config-digikam.h.cmake fb6644d509e198deae6ec5c8f8c54610a927df9b 
>   libs/database/schemaupdater.cpp 100edc948e48d2e282354714fcd69a9c5be4df72 
> 
> Diff: http://git.reviewboard.kde.org/r/109110/diff/
> 
> 
> Testing
> -------
> 
> digiKam compiles with and without SQLite v2.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130223/97f4381c/attachment.html>