[Digikam-devel] [digikam] [Bug 325925] Importer: Sorting order is not remembered

[Teemu Rytilahti]

https://bugs.kde.org/show_bug.cgi?id=325925

Teemu Rytilahti <tpr at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |tpr at iki.fi
     Ever confirmed|0                           |1

--- Comment #2 from Teemu Rytilahti <tpr at iki.fi> ---
I can confirm this. The settings are saved properly, but on load the change is
not being propagated properly. The relevant code is in
digikam/utilities/importui/main/importui.cpp's setupActions().

The naming of sorting functions/variables is a bit odd here, "Sorty by x" calls
view's slotSortImages(), but the current item is read from
ImportSettings::instance()->getImageSortOrder(). For ascending/descending the
call goes to slotSortImagesOrder() and the value is read from
getImageSorting(). Perhaps those are mixed or should there be separate calls
for setting the values on load? I'd suggest renaming those variables
nevertheless if possible. SortBy and SortOrder would be better names :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.