[Digikam-devel] New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity SCAN

Defect(s) Reported-by: Coverity Scan

	
** CID 1011530: Uninitialized scalar field (UNINIT_CTOR)
/mnt/devel/GIT/3.x/core/libs/database/collectionscannerhints.cpp: 302
http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10358#mergedDefectId=1011530

** CID 1011529: Resource leak in object (CTOR_DTOR_LEAK)
http://scan5.coverity.com:8080//sourcebrowser.htm?projectId=10358#mergedDefectId=1011529


________________________________________________________________________
CID 1011530: Uninitialized scalar field (UNINIT_CTOR)

/mnt/devel/GIT/3.x/core/libs/database/collectionscannerhints.h: 321 ( member_decl)
   318        qlonglong         m_id;
   319        AdjustmentStatus  m_status;
   320        QDateTime         m_modificationDate;
>>> Class member declaration for "m_fileSize".
   321        qlonglong         m_fileSize;
   322    };
   323    
   324    inline uint qHash(const Digikam::AlbumCopyMoveHint& hint)
   325    {
  

/mnt/devel/GIT/3.x/core/libs/database/collectionscannerhints.cpp: 302 ( uninit_member)
   299    ItemMetadataAdjustmentHint::ItemMetadataAdjustmentHint()
   300        : m_id(0), m_status(AboutToEditMetadata)
   301    {
>>> CID 1011530: Uninitialized scalar field (UNINIT_CTOR)
>>> Non-static class member "m_fileSize" is not initialized in this constructor nor in any functions that it calls.
   302    }
   303    
   304    ItemMetadataAdjustmentHint::ItemMetadataAdjustmentHint(qlonglong id, AdjustmentStatus status, 
   305                                                           const QDateTime& modificationDateOnDisk, qlonglong fileSize)
   306        : m_id(id), m_status(status), m_modificationDate(modificationDateOnDisk), m_fileSize(fileSize)
  
________________________________________________________________________
CID 1011529: Resource leak in object (CTOR_DTOR_LEAK)

/mnt/devel/GIT/3.x/core/digikam/database/scancontroller.cpp: 121 ( alloc_fn)
   118            advice(ScanController::Success),
   119            needTotalFiles(false),
   120            totalFilesToScan(0)
>>> CID 1011529: Resource leak in object (CTOR_DTOR_LEAK)
>>> Calling allocation function "Digikam::CollectionScanner::createHintContainer()".
   121        {
   122        }
   123    
   124        bool                      running;
   125        bool                      needsInitialization;
  

/mnt/devel/GIT/3.x/core/digikam/database/scancontroller.cpp: 121 ( var_assign)
   118            advice(ScanController::Success),
   119            needTotalFiles(false),
   120            totalFilesToScan(0)
>>> Assigning: "this->hints" = "Digikam::CollectionScanner::createHintContainer()".
   121        {
   122        }
   123    
   124        bool                      running;
   125        bool                      needsInitialization;
  

/mnt/devel/GIT/3.x/core/digikam/database/scancontroller.cpp: 121 ( ctor_dtor_leak)
   118            advice(ScanController::Success),
   119            needTotalFiles(false),
   120            totalFilesToScan(0)
>>> The constructor allocates field "hints" of "Digikam::ScanController::Private" but there is no destructor.
   121        {
   122        }
   123    
   124        bool                      running;
   125        bool                      needsInitialization;
  
________________________________________________________________________
To view the defects in Coverity Scan visit, http://scan5.coverity.com:8080

If you don't have a username, you can request one by emailing: scan-admin at coverity.com

To unsubscribe from the email notification for new defects, http://scan.coverity.com/email_unsubscribe.html
If you are project owner, you can subscribe your team member by accessing  http://scan.coverity.com/email_subscription.html