[Digikam-devel] crashing with old kipi plugins

[Gilles Caulier]

Marcel,

If the run-time check in libkipi do not fix the problem, we can try
another solution.

Why not to patch all plugin desktop file to include kipi-plugins
version ID. Like this before to load shared object through plugin
loader, we can check if version is right to be loaded without crash.

As with kipi-plugins < 3.0.0 this information do not exist, we can
prevent crash relevant of older plugins.

Note : i already patch common kipiplugins.desktop from libkipiplugins
with version ID :

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/common/libkipiplugins/kipiplugins.desktop.cmake#L96

It's easy to patch all plugins desktop files like this...

Gilles Caulier

2012/9/13 Gilles Caulier <caulier.gilles at gmail.com>:
> Yes, Marcel, I also seen this problem on my computer, and i don't find
> a way yet to solve this issue.
>
> Victor ?
>
> Gilles
>
> 2012/9/13 Marcel Wiesweg <marcel.wiesweg at gmx.de>:
>> Hi,
>>
>> once the beta is out we will get numerous crash reports from the kipi plugin
>> loader. The problem is that loading a kipi plugin compiled with old libkipi
>> crashes, the plugin is interpreted as XMLGuiClient which it is not.
>> Now, I got the crash and thought "we need to add some safety checks,
>> dynamic_cast, check ABI version of the plugin". I had a look and the code, and
>> Victor has done all that already. It seems the kipi2-constructor is called
>> from the kipi1 code, why not, the symbol has the same name.
>> Anyway, I dont have a good idea how to fix that. If there is no way, we shall
>> know to tell everyone first to remove old kipi plugins.
>>
>> Marcel
>> _______________________________________________
>> Digikam-devel mailing list
>> Digikam-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/digikam-devel