[Digikam-devel] [Bug 308489] raw image development produces artifacts in digikam 3.0.0-beta 2

[Robert Zeller]

https://bugs.kde.org/show_bug.cgi?id=308489

--- Comment #13 from Robert Zeller <robert.zeller at robert-zeller.org> ---
Gilles,

I re-downloaded digikam-3.0.0-beta2; and changed CMakelists.txt in 
extra/libkdcraw : I added -O4 in the options right after -fPIC and 
recompiled the source.
With the demosaic option "Interpolate rgb as four colors" turned on, I 
don't see the artefacts any more in the sample picture that I provided 
to you. BUT: on another raw-picture the faint rectangular pattern is 
still there, which is very strange. So my guess is: -O4 does not remove 
completely the problem. It is clearly dependent on turning on the option 
"Interpolate rgb as four colors". Do you want me to provide the other 
raw-picture that still evaluates the dysfunction?

Robert


On 10/29/2012 06:04 PM, Gilles Caulier wrote:
> https://bugs.kde.org/show_bug.cgi?id=308489
>
> --- Comment #12 from Gilles Caulier <caulier.gilles at gmail.com> ---
> Robert,
>
> Do not try to compile current implementation of libkdcraw with beta2. I changed
> API, for other reason, and digiKAm/Kipi-plugins from beta2 will not compile
> with it.
>
> Look my fix it's very simple. I just add -O4 option to compile libraw source
> code. Take libkdcraw source code from beta2 and just add -O4 option at the
> right place. In CMakeLists.txt you must find something like that :
>
> FOREACH(_curentfile ${libraw_LIB_SRCS})
>      IF(WIN32 AND MSVC)
>          SET_SOURCE_FILES_PROPERTIES(${_curentfile} PROPERTIES COMPILE_FLAGS
> "-w")
>      ELSE(WIN32 AND MSVC)
>          SET_SOURCE_FILES_PROPERTIES(${_curentfile} PROPERTIES COMPILE_FLAGS "-w
> -fPIC")
>      ENDIF(WIN32 AND MSVC)
> ENDFOREACH(_curentfile ${libraw_LIB_SRCS})
>
> In line including -fPIC option, just add -O4 at end. Recompile all, install,
> and test
>
> Gilles Caulier
>

-- 
You are receiving this mail because:
You are the assignee for the bug.