[Digikam-devel] [Bug 308534] libkexiv2 fails to build when exiv2 is built without XMP support

[Jekyll Wu]

https://bugs.kde.org/show_bug.cgi?id=308534

--- Comment #3 from Jekyll Wu <adaptee at gmail.com> ---
well, I don't mind building exiv2 with XMP support , but that is not the main
point of this report. The import thing is the code is now inconsistent with
itself :

#ifdef _XMP_SUPPORT_
    Exiv2::XmpData  xmpMetadata;
#endif

#ifdef _XMP_SUPPORT_
    Exiv2::XmpData&        xmpMetadata()         { return
data.data()->xmpMetadata;        }

    /**
     * Merge two XmpData packages, where the result is stored in dest
     * and fields from src take precedence over existing data from dest.
     */
    void mergeXmpData(const Exiv2::XmpData& src, Exiv2::XmpData& dest);
#endif

So either add more #ifdefs or remove those #ifdefs altogether and require XMP
support in exiv2, but the current state is just not right.

-- 
You are receiving this mail because:
You are the assignee for the bug.