[Digikam-devel] ImportContextMenuHelper vs ContextMenuHelper?

Gilles Caulier caulier.gilles at gmail.com
Tue Oct 9 22:08:18 BST 2012


Andi,

I come from Import tool no ? Ask to Islam, he has written this code...

Gilles

2012/10/9 Andi Clemens <andi.clemens at gmail.com>:
> Hi,
>
> what is the purpose of the ImportContextMenuHelper? Right now it seems to be
> a copy of the ContextMenuHelper, maybe with a slight variation.
>
> Wouldn't it make more sense if it was derived from ContextMenuHelper and
> just overwrites the methods it needs to change?
>
> I got a warning of my static code analysis tool chain about (massive) code
> duplication...
>
> Andi
>
>
> --
> Using Opera's revolutionary email client: http://www.opera.com/mail/
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel



More information about the Digikam-devel mailing list