[Digikam-devel] [Bug 274555] Digikam crashes while histogram computation

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=274555

Gilles Caulier <caulier.gilles at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel.wiesweg at gmx.de

--- Comment #39 from Gilles Caulier <caulier.gilles at gmail.com> ---
Marcel,

I have been able to reproduce the crash in ImageHistogram with 3.0.0 in certain
conditions, when Color tab is visible from right sidebar tab...

I ported all code relevant of histogram management to DImg and removed all
methods and constructors using pointer to uchar data container. In all case
this is more safe and clean. Code sound better.

I'm sure that it's a race condition relevant of image data deleted during
histogram computation. using DImg will prevent this. Also, i'm not able to
reproduce the crash now, after few intensive race condition test in my fast
computer.

It still a point to clear before to close this file. Look here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/dimg/filters/levels/imagehistogram.cpp#L90

Do i need really to make a deep copy of image here ? Because it will mangle
more memory, and i'm not sure that it must necessary to prevent race condition
of image data deleted. Typically the DImg shared data reference mechanism  must
be safe and enough. Right ?

Gilles

-- 
You are receiving this mail because:
You are the assignee for the bug.