[Digikam-devel] [Bug 295423] New: External libclapack not used

[nucleo]

https://bugs.kde.org/show_bug.cgi?id=295423

            Bug ID: 295423
          Severity: normal
           Version: unspecified
          Priority: NOR
          Assignee: digikam-devel at kde.org
           Summary: External libclapack not used
    Classification: Unclassified
                OS: Linux
          Reporter: nucleo at fedoraproject.org
          Hardware: Other
            Status: UNCONFIRMED
         Component: general
           Product: digikam

User-Agent:       Opera/9.80 (X11; Linux i686; U; ru) Presto/2.10.229
Version/11.61
Build Identifier: 

External libclapack not detected without this patch:

diff -ur digikam-2.1.1/core/cmake/modules/FindCLAPACK.cmake
digikam-2.1.1-clapack-atlas/core/cmake/modules/FindCLAPACK.cmake
--- digikam-2.1.1/core/cmake/modules/FindCLAPACK.cmake    2011-09-14
08:22:02.000000000 +0200
+++ digikam-2.1.1-clapack-atlas/core/cmake/modules/FindCLAPACK.cmake   
2011-09-23 07:09:37.000000000 +0200
@@ -27,7 +27,7 @@
      endif(CLAPACK_INCLUDE_DIR)
   endif(CLAPACK_INCLUDE_DIR)

-  find_library(CLAPACK_LIBRARY clapack)
+  find_library(CLAPACK_LIBRARY clapack PATH_SUFFIXES atlas)
   if(CLAPACK_LIBRARY)
       message(STATUS "Found clapack library: ${CLAPACK_LIBRARY}")
   endif(CLAPACK_LIBRARY)
diff -ur digikam-2.1.1/core/libs/dimg/filters/sharp/matrix.cpp
digikam-2.1.1-clapack-atlas/core/libs/dimg/filters/sharp/matrix.cpp
--- digikam-2.1.1/core/libs/dimg/filters/sharp/matrix.cpp    2011-09-14
08:22:03.000000000 +0200
+++ digikam-2.1.1-clapack-atlas/core/libs/dimg/filters/sharp/matrix.cpp   
2011-09-23 10:19:09.000000000 +0200
@@ -36,7 +36,6 @@

 extern "C"
 {
-#include "f2c.h"
 #include "clapack.h"
 }

@@ -653,14 +653,12 @@

 int RefocusMatrix::dgesv(const int N, const int NRHS, double* A, const int
lda, double* B, const int ldb)
 {
-    int result = 0;
-    integer i_N = N, i_NHRS = NRHS, i_lda = lda, i_ldb = ldb, info;
-    QScopedArrayPointer<integer> ipiv(new integer[N]);
+    int result;
+    QScopedArrayPointer<int> ipiv(new int[N]);

     // Clapack call.
-    dgesv_(&i_N, &i_NHRS, A, &i_lda, ipiv.data(), B, &i_ldb, &info);
+    result = clapack_dgesv (CblasColMajor, N, NRHS, A, lda, ipiv.data(), B,
ldb);

-    result = info;
     return (result);
 }



Reproducible: Always

Actual Results:  


Expected Results:

-- 
You are receiving this mail because:
You are the assignee for the bug.