[Digikam-devel] Review Request: Install LibKexiv2Config.cmake

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103701/#review9928
-----------------------------------------------------------


Looks good.
Did you verify that both building and using works with cmake 2.6.4 ?

- Alexander Neundorf


On Jan. 17, 2012, 11:58 p.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103701/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2012, 11:58 p.m.)
> 
> 
> Review request for Build System and Digikam.
> 
> 
> Description
> -------
> 
> Now
> find_package(LibKexiv2 NO_MODULE)
> finds LibKexiv2, removing need for large FindLibKexiv2.cmake script.
> 
> I've decided to install LibKexiv2Config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
> 
> P.S.: I think about moving large parts to a macro.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0ecd233 
>   LibKexiv2Config-external.cmake.in PRE-CREATION 
>   LibKexiv2Config.cmake.in PRE-CREATION 
>   LibKexiv2ConfigVersion.cmake.in PRE-CREATION 
>   libkexiv2/CMakeLists.txt 8a6b822 
> 
> Diff: http://git.reviewboard.kde.org/r/103701/diff/diff
> 
> 
> Testing
> -------
> 
> $ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20120118/dafbd791/attachment.html>