[Digikam-devel] Review Request: Install LibKexiv2Config.cmake

Alexander Neundorf neundorf at kde.org
Sun Jan 15 13:23:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103701/#review9829
-----------------------------------------------------------


Looks good in general, but: this patch makes libkexvi2 depend on cmake 2.8.6, due to the usage of WriteBasicConfigVersionFile.
kdelibs still depends on cmake 2.6.4.

So, I think this can't be committed as it is right now.

For KDE frameworks it would be ok, since this depends on cmake 2.8.7 right now and will depend on 2.8.8 once it has been released.
I'm not sure how to deal with kdelibs 4.x in this regard.
Let's discuss this on kde-buildsystem or k-c-d.

- Alexander Neundorf


On Jan. 14, 2012, 9:24 p.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103701/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2012, 9:24 p.m.)
> 
> 
> Review request for Build System and Digikam.
> 
> 
> Description
> -------
> 
> Now
> find_package(LibKexiv2 NO_MODULE)
> finds LibKexiv2, removing need for large FindLibKexiv2.cmake script.
> 
> I've decided to install LibKexiv2Config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
> 
> P.S.: I think about moving large parts to a macro.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0ecd233 
>   LibKexiv2Config-external.cmake.in PRE-CREATION 
>   LibKexiv2Config.cmake.in PRE-CREATION 
>   libkexiv2/CMakeLists.txt 8a6b822 
> 
> Diff: http://git.reviewboard.kde.org/r/103701/diff/diff
> 
> 
> Testing
> -------
> 
> $ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20120115/79647ec4/attachment.html>


More information about the Digikam-devel mailing list