[Digikam-devel] [Bug 283491] Caption/Tags tab: Active sub-tab not restored after restart [patch]

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=283491


Gilles Caulier <caulier.gilles at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67367|0                           |1
        is obsolete|                            |




--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2012-01-09 12:20:39 ---
Created an attachment (id=67613)
 --> (http://bugs.kde.org/attachment.cgi?id=67613)
reviewed patch for digiKam

reviewed patch for libkexiv2

Islam,

Look your second patch reviewed, including libkexiv2 version ID check to
prevent
broken digiKam compilation with old libkexiv2. 

This patch include too :

- coding polish.
- call of ImageDescEditTab::readSettings() from
ImagePropertiesSideBarDB::doLoadState() to read properly settings from digiKam
config file.
- call of ImageDescEditTab::writeSettings() from
ImagePropertiesSideBarDB::doSaveState() to save settings to digiKam config file
- some missing call, and wrong ordering of method calls.

I place patches in bugzilla for learning purpose. Please take a look. 

In all case, i will apply these patches to git /master.
Gilles Caulier

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.