[Digikam-devel] [Bug 291080] In settings, arrange ALL export options at ONE place

[Victor Dodon]

https://bugs.kde.org/show_bug.cgi?id=291080

--- Comment #22 from Victor Dodon <dodonvictor at gmail.com> ---
Gilles,
> 1/ Instead to use a dedicated method to group KAction + Category :
> 
>  void addAction(KAction* const action, Category cat);
> 
> ... why not to store Category in Kaction Container as extra data :
> 
> http://qt-project.org/doc/qt-4.8/qaction.html#setData
> http://qt-project.org/doc/qt-4.8/qaction.html#data
> 
> This will simplify code a lots...

I think that is more intuitive to use addAction(KAction* const, Category), and
in this way, plugins will no longer need the category method as it is
implemented in the Plugin class. This will also simplify the code a lot.

> 2/ Your last changes include to change both code + desktop files to describe
> Categories used in a plugin. Do you need that ?

Changes in the desktop files were necessary to know the plugin category even
when a plugin is not loaded. In the previous implementation we could not now
the plugin category if the plugin is not loaded. This is how it looked when
plugin were not loaded: http://img52.imageshack.us/img52/7243/shot50.png , and
this is how it looks now: http://img19.imageshack.us/img19/1152/shot49.png

> 3/ Instead to use code or/and desktop file to assign Categories in plugin,
> what's about to use XML file as well to add extra data in XML Action
> definition ? It's possible ? If yes, no code need to be changed and
> recompiled to assign or change Category, if libkipi is able to manage it...

As I can see from xmlgui standard
http://www.kde.org/standards/kxmlgui/1.0/kxmlgui.xsd accepted atributes for
Action are only: name, group, append, text, whatsThis, tooltip, iconText,
shortcut, icon, priority. And I don't think is a good idea to add non-standard
attributes.

-- 
You are receiving this mail because:
You are the assignee for the bug.