[Digikam-devel] [Bug 297614] Maintenance tool disabled after running some tasks

Andi Clemens andi.clemens at googlemail.com
Sat Apr 7 10:39:27 BST 2012


https://bugs.kde.org/show_bug.cgi?id=297614

--- Comment #6 from Andi Clemens <andi.clemens at googlemail.com> ---
Git commit 4abf4766f5e759cd7f9e86cad6087a7bd7c59bf5 by Andi Clemens.
Committed on 07/04/2012 at 11:39.
Pushed by aclemens into branch 'master'.

Do not start a tool immediately in the constructor. This will lead to race
conditions.
Also we try to connect signals to tools AFTER they started doing their job.
This will not work for tasks that close immediately, e.g. "Scan for new items"
on a very small collection. In this case the signal becomes connected AFTER the
tool is done, therefore never executing the assigned slot. There are still some
race conditions left, I need to check them, but for now the main issue in this
bug report should be solved.

M  +2    -1    digikam/album/albumselectiontreeview.cpp
M  +4    -2    digikam/main/digikamapp.cpp
M  +2    -1    digikam/views/leftsidebarwidgets.cpp
M  +2    -1    utilities/cameragui/main/cameraui.cpp
M  +4    -1    utilities/fuzzysearch/findduplicatesview.cpp
M  +2    -1    utilities/fuzzysearch/fuzzysearchview.cpp
M  +0    -4    utilities/maintenance/duplicatesfinder.cpp
M  +0    -5    utilities/maintenance/facedetector.cpp
M  +7    -2    utilities/maintenance/fingerprintsgenerator.cpp
M  +12   -0    utilities/maintenance/maintenancemngr.cpp
M  +5    -0    utilities/maintenance/maintenancetool.cpp
M  +2    -0    utilities/maintenance/maintenancetool.h
M  +0    -6    utilities/maintenance/metadatasynchronizer.cpp
M  +0    -2    utilities/maintenance/newitemsfinder.cpp
M  +0    -10   utilities/maintenance/thumbsgenerator.cpp
M  +2    -1    utilities/setup/setupcollectionview.cpp

http://commits.kde.org/digikam/4abf4766f5e759cd7f9e86cad6087a7bd7c59bf5

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Digikam-devel mailing list