[Digikam-devel] [Bug 286719] Digikam hang during startup (deadlock?)

Oldřich Jedlička oldium.pro at seznam.cz
Wed Nov 16 07:35:28 GMT 2011


https://bugs.kde.org/show_bug.cgi?id=286719





--- Comment #5 from Oldřich Jedlička <oldium pro seznam cz>  2011-11-16 07:35:28 ---
I've checked the CollectionManager::updateLocations (Thread 4):

The need to have class DatabaseAccessUnlock points to the real problem - the
locking is screwed. If there are methods that need to have the database
unlocked then they should be called as such.

Moreover, the DatabaseAccessUnlock is written for multi-threaded environment.
The constructor frees all locks, but there is no guarantee that the lock will
be obtained from other thread after the constructor returns. This just cannot
work without locking...

I think this class is dangerous in the way it cannot actually do what it
declares, so it should be removed and the methods fixed. Maybe the
CollectionManagerPrivate::listVolumes method could be revised for thread-safety
with KDE 4.7 again (according to the comment inside the method).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Digikam-devel mailing list