[Digikam-devel] [Bug 274029] Edit Metadata dialog doesn't honour settings for XMP sidecar

[Daniel Berrange]

https://bugs.kde.org/show_bug.cgi?id=274029





--- Comment #1 from Daniel Berrange <dan berrange com>  2011-05-24 15:05:12 ---
Created an attachment (id=60270)
 --> (http://bugs.kde.org/attachment.cgi?id=60270)
Fix kipi-plugins to load digikam settings before load/save of metadata via
KExiv2

Debugging the code revealed that the use of the KExiv2 class in
extra/kipi-plugins/metadataedit/ was incorrect. Some places did not apply any
of the Digikam settings for metadata usage, and others only applied the
WriteMetadataUpdateFiletimeStamp & WriteMetadataToRAW settings.

The usage pattern of KExiv2 seems rather error-prone, requiring every piece of
code to remember to manually load digikam metadata settings into the object
instance. I wasn't sure of the history and/plans for improving this, so rather
than re-factor it myself, I'm providing a minimal patch which simply follows
the current coding practice. Specifically the patch just updates all code in
extra/kipi-plugins/metadataedit/  to apply WriteMetadataToRAW,
MetadataWritingMode, UseXMPSidecar4Reading and
WriteMetadataUpdateFiletimeStamp.

In my testing, this makes the 'Edit All Metadata' dialog correctly handle XMP
sidecars as per digikam settings. Some of the kipi-plugins look like they might
also need work in this area though.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.