[Digikam-devel] [Bug 269846] New: TIFF loader is broken on big-endian architectures [PATCH]

[pochini at shiny.it]

https://bugs.kde.org/show_bug.cgi?id=269846

           Summary: TIFF loader is broken on big-endian architectures
                    [PATCH]
           Product: digikam
           Version: 2.0.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel at kde.org
        ReportedBy: pochini at shiny.it


Created an attachment (id=58481)
 --> (http://bugs.kde.org/attachment.cgi?id=58481)
Fix TIFF loader on big-endian architectures

Version:           2.0.0 (using KDE 4.5.2) 
OS:                Linux

In the TIFF loader all those if-QSysInfo::ByteOrder in the 16 bits color path
are wrong because the order of color components is always the same for any
architecture. I removed all of them and I left the "else" code paths only.

NOTE: I was able to test only the 3-samples-per-pixel PLANARCONFIG_CONTIG part
of the code because I haven't images in other formats.

The 8 bits image loader is fine.

The saver is also buggy, but the bugs cancel each other when !imageHasAlpha().
There are also other issues I will investigate (and try to fix) later.
The attached patch fixes the loader only. I wrote and tested it for 1.8.0 and
forward ported it to the latest GIT version.

Reproducible: Always

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.