[Digikam-devel] [Bug 208504] Add type icon to images under the thumbnail (patch)

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=208504





--- Comment #20 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-03-19 14:48:38 ---
finstrodela...: Not everyone has the size enabled. There is a very large number
of possible combinations.

Gilles:
I see several problems with this patch:

- the large, black item with bold letters and sharp corners is very dominating,
and I dont like it aesthetically:
http://wstaw.org/m/2011/03/19/plasma-desktopd25183.jpg
- it collides with the group indicator (which is itself no optimal and has no
better place atm):
http://wstaw.org/m/2011/03/19/plasma-desktopo25183.jpg
- In the thumbnail bar, the filename is cut:
http://wstaw.org/m/2011/03/19/plasma-desktopu25183.jpg
I assume a problem in the drawName method, where bRect's width is set.
Both text dont really now of each other; the format is drawn at a fixed
position, and the name in the center. The name should be drawn offset to the
left.
- Compare the current unpatched version: You see that the filename's font is
much smaller. Is it reset to larger size somewhere?
- the thumbnail bar is now wasting space, if the name is not displayed but the
rating: http://wstaw.org/m/2011/03/19/plasma-desktopp25183.jpg Previously, it
was more compact, although sometimes a nuisance to click on the rating. So this
has pros and cons.

I'm not quite sure either how to do this best. I like the second mockup above;
but it's done for a specific set of options, and with 8 options we are at 256
different combinations. In addition to that, thumbnail size differs, and the
situation is so much different for 64px thumbs than for 160px.

I agree to combine format + filename if both are selected, seems to make sense.
Especially if the suffix is cut if the format is displayed as well. I would
suggest using the smaller font for the filename like for all other fields.

There are already so many options, but I have a feeling that the thumbbar needs
different settings than the main icon view. You can have large thumbnails and
tiny thumbs in the thumbbar. You may want everything displayed in the icon
view, and nothing in the thumbbar. Very difficult to get it all right.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.