[Digikam-devel] Re: [Bug 267789] Make face detection (kface) and geo tagging (kmap) optional features

[Alex Jironkin]

K, So here is a quick low down on what I did and why. There was a memory leak as the pointer wasn't released when libface::Face was destroyed. So I have added that, which ultimately meant that no Face objects could be on stack, as they would be destroyed and subsequently pointer released. So I have changed the vectors to only contain pointers to the Face objects, meaning pointer wasn't released unnecessary, and would also cut down on amount of memory allocated. 

This has resulted in downstream changes to interface. Subsequently some changes had to be made in libkface to accommodate for the same reasons. So I have changed a lot of QList<Face> references internally to QList<Face*> . I have made all necessary changes to the libkface and everything compiles fine. Except as I have described before there is a segfault in detection, which I haven't figured out yet. The patch is rather large to submit here because of all the changes, none the less I can still make it and post it here so everyone can patch it up.

On the different note I have merged the 0.2 branch with trunk so the latest copy is there. There is a 0.1 folder in the tags, if anyone needs the 0.1 copy.


Alex

On 13 Mar 2011, at 21:44, Marcel Wiesweg wrote:

> 
>> 1) Use the libface-0.2 branch from now to continue work on libface-0.2:
>> git checkout -b libface-0.2 origin/libface-0.2
> 
> Alex, as you have local changes: Do not git pull --rebase first. Store the 
> changes with git stash, then checkout the branch as above, then reapply with 
> git stash pop.
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel

If we knew what we were doing, it wouldn't be called research, would it?
-- Albert Einstein